Conversation
Add a templated Helm chart under helm/ for deploying Logflare to Kubernetes, along with a GitHub Actions workflow that gates chart changes on pull requests. The workflow runs only on PRs that touch helm/**, and it: - installs Helm and the helm-unittest plugin - lints the chart - runs the chart unit tests - renders the chart with default values via helm template - verifies the chart version in Chart.yaml has been bumped above main
Ziinc
marked this pull request as ready for review
July 22, 2026 14:45
stigglor
commented
Jul 23, 2026
…3728) Builds on the initial chart to support the full secret/config surface a production deployment needs: - certFilesSecret / certFilesMountPath: mount a Secret of cert/key files (DB SSL + gRPC TLS) as files, and point the DB_SSL_*_PATH / LOGFLARE_TLS_*_PATH env vars at the mount. Logflare reads these from disk, so envFrom can't carry them. (Requires the configurable-path support in logflare runtime.exs.) - reloader: optional Stakater Reloader annotation so the Deployment rolls when its ConfigMap or referenced Secrets change (the chart can't checksum Secrets it doesn't own). - extraConfig: free-form passthrough of non-secret env vars into the ConfigMap, for the long tail of configuration not modeled as first-class values. Adds helm-unittest coverage for each and documents them in the README. All new behavior is default-off, so existing rendering is unchanged.
This was referenced Jul 24, 2026
Adds an opt-in `vmArgs` value rendered into a ConfigMap, mounted at /etc/logflare/vm.args, and wired via RELEASE_VM_ARGS. Defaults to a set including `+Q 1048576`, which caps the BEAM's preallocated port table — needed on Kubernetes, where containerd runs pods with nofile=infinity and the VM would otherwise size the table from that (~2GB RSS at boot). Mounted with subPath so it coexists with the cert-files mount under /etc/logflare. A checksum/vm-args pod annotation rolls the Deployment when the args change. Set vmArgs to "" to fall back to the image's baked-in vm.args. Adds helm-unittest coverage.
#3736) * feat(helm): support custom vm.args via RELEASE_VM_ARGS Adds an opt-in `vmArgs` value rendered into a ConfigMap, mounted at /etc/logflare/vm.args, and wired via RELEASE_VM_ARGS. Defaults to a set including `+Q 1048576`, which caps the BEAM's preallocated port table — needed on Kubernetes, where containerd runs pods with nofile=infinity and the VM would otherwise size the table from that (~2GB RSS at boot). Mounted with subPath so it coexists with the cert-files mount under /etc/logflare. A checksum/vm-args pod annotation rolls the Deployment when the args change. Set vmArgs to "" to fall back to the image's baked-in vm.args. Adds helm-unittest coverage. * feat(helm): replace Stakater-specific reloader toggle with generic deploymentAnnotations Per review on #3728: the `logflare.reloader` boolean hard-coded a Stakater- specific annotation, which is too opinionated for a public chart. Replace it with a generic top-level `deploymentAnnotations` map (mirroring podAnnotations) that renders onto the Deployment's own metadata.annotations. This keeps the chart neutral about the reload mechanism — opt into Reloader with `deploymentAnnotations: { reloader.stakater.com/auto: "true" }` — and fills a real gap: there was no hook for Deployment-level annotations (podAnnotations only reaches the pod template). Updates the helm-unittest cases and README.
Render ExternalSecret resources directly from the chart when externalSecrets.enabled is true, so ESO users can sync secrets without hand-writing the ExternalSecrets. Off by default, so the chart still renders no Secret and takes no dependency on ESO CRDs for anyone who does not use it. The (Cluster)SecretStore name/kind and every remote path live under a single externalSecrets block in values. Each entry maps keys to data[].remoteRef (secretKey is the key, remoteRef.key is remotePrefix/key), with verbatim data/dataFrom passthrough for cases keys cannot express. The block is ESO-specific by design, leaving room for sibling provider blocks (e.g. Vault) later. Adds helm-unittest coverage and README docs, and bumps the chart to 0.2.0.
Co-authored-by: depthfirst-app[bot] <184448029+depthfirst-app[bot]@users.noreply.github.com>
List every template deployment.yaml includes in each suite's templates key, so helm-unittest compiles configmap.yaml and vm-args-configmap.yaml and the checksum includes resolve instead of erroring. Rewrite the cert-file volume and mount assertions to use contains/notContains keyed on the volume name rather than a fixed [0] index, since vmArgs is enabled by default and its vm-args volume now occupies index 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an initial (templated) Helm chart under
helm/for deploying Logflare to Kubernetes, plus aHelm ChartGitHub Actions workflow to validate chart changes.Why
Gives us a versioned, testable deployment artifact for Kubernetes and enforces basic quality gates so chart changes can't merge broken or without a version bump.
Workflow behavior
Runs only on pull requests, and only when the diff touches
helm/**:helm-unittestpluginhelm lintthe charthelm unittest -f '*_test.yaml' helm)helm template helm)versioninhelm/Chart.yamlhas not been bumped above the base branch (skips this check when no chart exists on the base yet)